[scheduler][styled] Allow to have nested resources #20108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-20108--material-ui-x.netlify.app/ Bundle size report
|
noraleonte
added
the
type: new feature
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
packages/x-scheduler-headless/src/scheduler-selectors/schedulerSelectors.ts
Outdated
Show resolved
Hide resolved
packages/x-scheduler-headless/src/scheduler-selectors/schedulerSelectors.ts
Outdated
Show resolved
Hide resolved
...adless/src/use-event-occurrences-grouped-by-resource/useEventOccurencesGroupedByResource.tsx
Outdated
Show resolved
Hide resolved
packages/x-scheduler-headless/src/utils/SchedulerStore/SchedulerStore.types.ts
Outdated
Show resolved
Hide resolved
packages/x-scheduler-headless/src/utils/SchedulerStore/SchedulerStore.types.ts
Outdated
Show resolved
Hide resolved
packages/x-scheduler-headless/src/utils/SchedulerStore/SchedulerStore.utils.ts
Outdated
Show resolved
Hide resolved
packages/x-scheduler/src/internals/components/resource-legend/ResourceLegend.tsx
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
packages/x-scheduler-headless/src/scheduler-selectors/schedulerResourceSelectors.ts
Outdated
Show resolved
Hide resolved
packages/x-scheduler-headless/src/scheduler-selectors/schedulerResourceSelectors.ts
Outdated
Show resolved
Hide resolved
packages/x-scheduler-headless/src/scheduler-selectors/schedulerResourceSelectors.ts
Outdated
Show resolved
Hide resolved
packages/x-scheduler-headless/src/scheduler-selectors/schedulerResourceSelectors.ts
Outdated
Show resolved
Hide resolved
packages/x-scheduler-headless/src/scheduler-selectors/schedulerResourceSelectors.ts
Outdated
Show resolved
Hide resolved
packages/x-scheduler-headless/src/scheduler-selectors/schedulerResourceSelectors.ts
Outdated
Show resolved
Hide resolved
packages/x-scheduler-headless/src/scheduler-selectors/schedulerResourceSelectors.ts
Outdated
Show resolved
Hide resolved
packages/x-scheduler-headless/src/scheduler-selectors/schedulerResourceSelectors.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Flavien DELANGLE <[email protected]> Signed-off-by: Nora <[email protected]>
flaviendelangle
approved these changes
Nov 10, 2025
Member
flaviendelangle
left a comment
flaviendelangle
left a comment
There was a problem hiding this comment.
One last feedback and we are good to go 👍
| if (children) { | ||
| for (const child of children) { | ||
| if (!resourceChildrenIdLookup.get(processedResource.id)) { | ||
| resourceChildrenIdLookup.set(processedResource.id, []); |
Member
There was a problem hiding this comment.
I think you should be able to generate resourceChildrenIdLookup in a selector instead of storing it in the state. It' just derived from processedResourceLookup right?
Contributor
Author
There was a problem hiding this comment.
hmm, not sure we can 🤔 i separated the children ids resourceChildrenIdLookup and processedResourceLookup only keeps the resource data without its children nested 😬
Member
There was a problem hiding this comment.
OK we can keep it as is and refacto later if needs be 👍
bernardobelchior
added a commit
to bernardobelchior/mui-x
that referenced
this pull request
Nov 19, 2025
This reverts commit beea7d6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19494